userbinator 3 days ago

It's a big omission to claim "minimalist" but then have no information about code size. Nonetheless, as someone who has written an H.261 through H.263 decoder as a learning exercise, it's good to see more people writing video codecs. Getting high performance may not be straightforward, but the algorithms themselves are well-defined by the standard.

Access to left/top macroblock values is done with direct offsets in memory instead of copying their values to a buffer beforehand.

I made use of this technique too, so I think it's not particularly novel nor non-obvious. The performance-sensitivity of video decoding necessarily means avoiding any extraneous data movement whenever possible.

Also worth noting: H.264 patents have already expired in most of the world: https://meta.wikimedia.org/wiki/Have_the_patents_for_H.264_M...

jwr 2 days ago

From someone who has worked on H.264 decoding and done some assembly optimization: this is an insanely complex task and a huge effort. Kudos to the author(s).

ebb_earl_co 3 days ago

I like the `VARIANTS` env. var [0] to take advantage of x86_64 newer extensions if one’s processor has them.

CachyOS is a whole distro compiled with these flags, if possible, which is appealing.

[0] https://github.com/tvlabs/edge264#compiling-and-testing

  • kimixa 3 days ago

    I wonder why they use multiple executables instead of something like function multiversioning [0]

    [0] https://gcc.gnu.org/onlinedocs/gcc/Function-Multiversioning....

    • kg 3 days ago

      Function multiversioning would require indirect jumps/indirect calls, wouldn't it? Separate executables can do static jumps/calls.

      • kimixa 3 days ago

        On linux it uses IFUNC resolved at load/dynamic relocation time, so at runtime it's the same cost as any other (relocatable) function call. But they're "static" in that it's not a calculated address so pretty easy for a superscaler CPU to follow.

        So it does have some limitations like not being inlined, same as any other external function.

        • amluto 3 days ago

          Since TEXTREL is basically gone these days (for good reasons!), IFUNC is the same as any other call that is relocatable to a target not in the same DSO. Which is either a GOT or PLT, either of which ends up being an indirect call (or branch if the compiler feels like it and the PLT isn’t involved). Which is what the person you’re replying to said :)

          A relocatable call within the same DSO can be a PC-relative relocation, which is not a relocation at all when you load the DSO and ends up as a plain PC-relative branch or call.

          • kimixa 3 days ago

            Sure, but they're already paying that cost for every non-static function anyway. Any DSO, or executable that allows function interposition, already pays.

            Ideally you should just multiversion the topmost exported symbol, everything below that should either directly inlined, or, as the architecture variant is known statically by the compiler, variants and a direct call generated. I know at least GCC can do this variant generation for things like constant propagation over static function boundaries, so /assume/ it can do the same for other optimization variants like this, but admittedly haven't checked.

        • eru 3 days ago

          What about duplicating the entire executable essentially a few times, and jumping to the right version at the very beginning of execution?

          You have bigger binaries, but the logistics are simplified compared to shipping multiple binaries and you should get the same speed as multiple binaries with fully inlined code.

          Since they don't seem to be doing that, my question is: what's the caveat I'm missing? (Or are the bigger binaries enough of a caveat by themselves?)

          • astrange 3 days ago

            There's no need to do any of that, a table of function pointers to DSP functions works fine.

            It can be useful to duplicate the entire code for 8-bit vs 10-bit pixels because that does affect nearly everything.

          • mikepurvis 3 days ago

            Ideally you only need to duplicate until you hit the first not-inlined function call; at that point there’s nothing gained and it’s just a waste of binary size.

    • nnevatie 2 days ago

      Portable multi-versioning is kind of hard to set up. E.g. compilers on Linux are not happy to emit AVX512 intrinsics when the architecture isn't enabled via -m... - this is also true for the case where you're trying to setup a dispatching system relying on cpuid, etc.

      • Sesse__ 2 days ago

        Is this specific to AVX512? It works well for e.g. AVX2.

        • nnevatie 2 days ago

          Yes, at least on AVX512 the compiler will throw a fit on trying to use intrinsics in case you haven't enabled TU-global architecture with options.

          • Sesse__ 2 days ago

            Seems to work fine for me: https://gcc.godbolt.org/z/hPexshjoa

            • nnevatie 2 days ago

              Likely a different compiler/version. GCC had this error for me recently:

              error: inlining failed in call to 'always_inline' 'float _mm512_reduce_add_ps(__m512)': target specific option mismatch

              • Sesse__ 2 days ago

                Compiler Explorer link or it didn't happen? :-)

    • pjmlp 3 days ago

      To keep code portable?

wyattblue 3 days ago

This may eventually be better for people working in the cloud. Shame there's no apple silicon support.

(See also Cisco's openh264, which supports decoding)

  • zamadatix 3 days ago

    Don't all Apple Silicon devices have extremely good (in both speed and feature coverage) H.264 hardware decoders already?

    • CharlesW 3 days ago

      Yes. If there's a hole in macOS's VideoToolbox support it's the middling quality of their hardware-accelerated encoder, so people who want high quality encodes will generally use x264/x265 for that.

    • sroussey 3 days ago

      Yes, H.264 is in hardware on Apple Silicon.

      But as a software decoder which is specifically made to not use hardware APIs for decoding, I am not sure why they skipped ARM64 on non-linux platforms.

      • zamadatix 3 days ago

        But why go through the trouble of building and shipping a software decoder for a platform you know has no devices which need such a thing? On the other hand it's not too hard to find ARM64 Linux devices which need an efficient software decoder (either because there isn't a hardware one at all, there one that is there is limited in feature support, or the one that is there is hybrid but written so poorly a good software decoder is more efficient).

      • mikepurvis 3 days ago

        Out of curiosity, what does “in hardware” actually mean in this context? Is it pure vhdl? Microcode that leverages special primitives? Something else?

        • bri3d 3 days ago

          In the case of Apple AVD, it's a multi-stage system with a bunch of special primitives, orchestrated by a Cortex-M3 with firmware. Codec-specific frontends emit IR which a less specialized backend can execute.

          https://github.com/eiln/avd

          This really heavily depends on the device, though. There are all sorts of "hardware" video decoders ranging from fairly generic vector coprocessors running firmware to "pure" HDL/VLSI level implementations. Usually on more modern or advanced hardware you'll see more and more become more general purpose, since a lot of the later stages can be shared across codecs, saving area vs. a pure hardware implementation.

      • antihero 2 days ago

        Do we have hardware H.265 or other more current codec support in hardware on anything?

        • galad87 2 days ago

          Yes, almost everything out there supports at least H.265, H.264, VP9, and AV1 in hardware.

  • astrange 3 days ago

    I don't see why this would support Linux arm64 but not macOS.

    Anyway, you can just use libavcodec, which is faster (because of frame based multithreading) and doesn't operate on the mistaken belief that it's a good idea to use SIMD intrinsics.

    • wyattblue 18 hours ago

      That's a good catch. I did not notice there weren't using any assembly at all. I assumed they wanted to add NEON before advertising Apple Silicon but I guess not.

      Also, hi FFmpeg twitter.

    • fisf 2 days ago

      Care to ellaborate? Not shitting on libavcodec here, I would also guess it just beats a new project on raw performance.

      But according to the repo, this project also uses both slice and frame multi-threading (as does ffmpeg, with all the tradeoffs).

      And SIMD usage is basically table-stakes, and libavcodec uses SIMD all over the place?

      • astrange 2 days ago

        > But according to the repo, this project also uses both slice and frame multi-threading (as does ffmpeg, with all the tradeoffs).

        Oh, I missed that since it doesn't have a separate file. In that case they're likely very similar performance-wise. H.264 wasn't well-designed for CPUs because the arithmetic coding could've been done better, but it's not that challenging these days.

        > And SIMD usage is basically table-stakes, and libavcodec uses SIMD all over the place?

        SIMD _intrinsics_. libavcodec doesn't write DSP functions in assembly for historical reasons - it's because it's just better! It's faster, just as maintainable, at least as easy to read and write, and not any less portable (since it already isn't portable…). They're basically a poor way to generate the code you want, interfere with other optimizations like autovectorization, and you might as well write your own code generator instead.

        The downsides are it's harder to debug and analyzers like ASan don't work.

  • bri3d 3 days ago

    I had no issues getting this to build, pass tests, and render a video on ARM64 Mac OS X.

giorgioz 2 days ago

What are the use cases for this? How can I use this instead of existing decidere and save money?