mrkeen 6 hours ago

Type systems are hard! Check out https://counterexamples.org/

I gave it a quick scan for Rust examples; there are 11 samples among the following pages:

  https://counterexamples.org/eventually-nothing.html
  https://counterexamples.org/mutable-matching.html
  https://counterexamples.org/selfishness.html
  https://counterexamples.org/scope-escape.html
  https://counterexamples.org/nearly-universal.html

The first thing I always look for is mutability (combined with some other tricky feature), e.g. "Now it's a Just(3):Maybe<Int>, now it's a Nothing:Maybe<Int>, now it's a Nothing:Maybe<String>."

I wonder if TFA's example could be reproduced without mutability.

  • vrighter 5 hours ago

    so what I take from this is that the rust compiler does not guarantee the stuff it claims to. Because new features of the type system is just being yolod instead of formally proven

    EDIT: I said new features of the type system and more importantly, their interactions with the ever growing list of other features, not new features in the compiler. Totally different things. The compiler could be perfectly implementing the wrong choice of algorithms in the first place.

    • thfuran 5 hours ago

      No mainstream compiler is formally proven. If you want a verified compiler, you pretty much have to choose between using a subset of standardml or a subset of C and the one proven compiler for each.

      • vrighter 4 hours ago

        You're mistaking the semantics of the type system, from the implementation. I'm not talking about verifying the compiler. There's nothing to verify there.... literally. There is no spec to the language. By definition it is verified because the only verification you can do is tautological: "does this rust compiler do what this rust compiler does?"

        But the unsoundness is because the type system itself, abstractly, was not verified. Or the interactions between parts. I.e. If you verified the compiler you'll find that it implements the algorithms perfectly. But tells you nothing about whether those implemented algorithms, however perfectly implemented, actually provided those guarantees.

        • vlovich123 3 hours ago

          They probably meant things like LLVM and the various optimization passes. None of those are verified, there’s probably all sorts of correctness issues, and yet it’s still ok. Rust’s usage also has issues and bugs emitting the right intermediate form for LLVM to consume and usually also it’s ok.

          Would it be nice if we had even higher level of quality? Yes. But what’s neat is we have empirical evidence - Rust code does achieve the memory safety goals over C++ even though there’s bugs in the compiler. That’s why Rust is very quickly eating all things C and C++. A huge amount of value that the industry would just be unable to access for a long time if you waited for everything to be formally proven.

    • csande17 5 hours ago

      Yes. When people describe Rust as "a memory-safe programming language" they are describing an aspirational vision, and not a programming language that has actually been designed with sufficient rigor to guarantee memory safety. Any failure of rustc to actually guarantee this is just a bug in rustc itself, a failure to properly implement the Rust spec, because the closest thing Rust has to a spec is literally just the vague ideal that the compiler should guarantee safety somehow.

      Rust cannot fail, it can only be failed.

      • lolakutty 5 hours ago

        >Rust cannot fail, it can only be failed...

        Sweet. But why should anyone care..

      • UncleMeat 5 hours ago

        Would you say the same thing about Java? It’s type system is also unsound.

        • csande17 5 hours ago

          I'm not an expert on the Java specification, but my understanding is that Java as a language is well-defined enough that we can say things like "Java's type system is unsound", independently from any specific implementation of Java.

          You can't do that with Rust because "Rust's type system" is literally just the vague concept of "a type system that is safe". The implementation of this ideal in rustc can have flaws, but Rust itself cannot, because Rust itself has no flaws by definition.

          • mcherm 3 hours ago

            It is true that Rust does not have a complete formal specification for its type system which has been analyzed and proven to be sound.

            You seem to be implying that because of this, Rust has no definition of its type system (other than whatever happens to be implemented in the current compiler). I would disagree.

            As evidence, I would like to point out that not a single person argued that this flaw was not a bug, but was in fact the officially defined behavior. Clearly, the community has a shared understanding of what Rust's type system "ought" to do.

            • csande17 1 hour ago

              The true specification was inside our hearts all along!

              • Ar-Curunir 45 minutes ago

                I mean yes, part of our understanding of systems is a social one!

                • eru 6 minutes ago

                  Haskell is in a similar boat with regards to a missing formal spec.

        • vrighter 4 hours ago

          but it isn't claiming to be saving you from things it can't prove it can either.

      • insanitybit 5 hours ago

        I don't think the definition of "memory safe" has ever required full end to end stack conformance with a proof. Very few languages have achieved that, though some have. Most people call Java memory safe, C#, Python, Typescript, etc - all of those fall short of a formally verified, sound type system with a verified toolchain.

        • afdbcreid 5 hours ago

          Not to talk about Go, which has intentional unchecked-at-runtime UB (data races) yet many argue to consider it memory safe (and I have a feeling that the same people arguing Rust isn't memory safe are also there. Just a feeling though).

      • DriverDaily 5 hours ago

        > Rust cannot fail, it can only be failed.

        “Please build the perfect system. Because I specified ‘perfect’ any flaws are due to your incomplete implementation, not my awful brief.”

        If the person writing the rust spec was a client I would have to drop them because they would be setting themselves up for dissatisfaction.

    • roblabla 5 hours ago

      There never was formal verification of the entire rust compiler, or even its complete borrow checker/type system. There has been verifications on _subsets_ of them.

      Also, a lot of those soundness issues aren't related to new features _at all_, but usually due to poor assumptions made in optimizations.

      The soundness bugs _are_ taken seriously though, and are slowly being patched out. A lot of the links in OP are now closed because Rust either changed how it generates code to avoid the issues, or fixed LLVM.

      • vrighter 5 hours ago

        not of the implementation. Of the type system. And a verification of subsets, but not a verification of their interactions == the whole system is unverified.

        • streetfighter64 4 hours ago

          It holds that ¬(∀subsets: isverified(subset)) but it's not true that ∀subsets: ¬isverified(subset), which it think most people would interpret "the whole system is unverified" as

          • vrighter 3 hours ago

            If I independently verify that subsystem A properly consumes apples, and that subsystem B is properly emitting oranges, but never verify that subsystem A is receiving apples, and just connect subsystem B to it, then yeah, the system is not verified.

            • samus 2 hours ago

              That's not the issue though.

            • cmrx64 2 hours ago

              you’re deeply confused but the words “validation” and “qualification” may help untangle the web, there’s a lot more to assurance than what your model seems to hold (and you’re drawing batshit deductions from it)

        • afdbcreid 4 hours ago

          The eventual goal is verification of the full system. Not the implementation, yes, that's infeasible. But this will mean all soundness bugs will be either found and fixed or we'll know how to fix them once they're found. In any way they won't be fundamental (which is believed to be the case today, but not proven).

          • vrighter 4 hours ago

            so why put them in before knowing if they work reliably? That's the YOLO part, to me

            • dwattttt 3 hours ago

              You're claiming that this bug that reproduces back to Rust 1.4 (2015) is a sign they're adding too many features to make sure they don't introduce bugs? Or do you have bugs that are due to these recent features?

            • cscheid 3 hours ago

              The same combination of reasons we've been doing these kinds of heuristic implementations forever:

              - people still get value off of an incomplete implementation, because we are allowed to be mindful of the issues (see, eg, UB in C++). In other words, many, many more bugs have been prevented by the borrow checker working as intended than have been caused by it working poorly. It's not particularly close.

              - theory almost always moves slower than practice

              The mutable state situation pointed out by the grandparent poster was a famous issue in typing SML under mutability that required serious changes in the language, see Section 4.2 here: https://smlfamily.github.io/history/SML-history.pdf

              These were Turing-award caliber people figuring it out and, according to your definition, "yolo"ed it. This stuff is _hard_, and these driveby comments truly aren't helpful.

            • vlovich123 3 hours ago

              Because there’s real value delivered even before that? Perfect bring the enemy of good and all that

    • jeremyjh 5 hours ago

      There is a massive possibility space between “yolo” and formal proof. Rust has substantial evidence of correctness. For example, unit tests and types.

      • vrighter 4 hours ago

        That's verifying the implementation. The type system wasn't verified. It implements stuff perfectly, it has tests that prove it, but nobody formally verified that they perfectly implemented the correct algorithms

        • bluGill 4 hours ago

          Tests are not perfect, but they are a lot better than where we were in 1990.

          • vrighter 4 hours ago

            completely tangential to whether you're testing for the right thing.

            • bluGill 2 hours ago

              We are a lot closer to testing the right thing today than we were in 1990!

              There are pros and cons to tests, but they do some things very well. For starters a test is a lot better sign that things work as intended than a formal proof which is often so abstract most people can't be sure how it relates to what was intended. You can prove something correct that is clearly wrong. While a test will only test the one case, at least it is typically easy to understand that case and why that answer is correct. Of course if your requirements are correct your proof will tell you it is correct for all cases while a test is limited to that one case. Again pros and cons, and people speaking against tests are not honest about those.

    • UncleMeat 5 hours ago

      The Java type system is also unsound. That’s life. It is hard to do this fully correctly. In practice this never comes up.

      • afdbcreid 5 hours ago

        While true, there are two important differences:

        1) Unsoundnesses in Java's type system are checked at runtime.

        2) They (or at least some) are intentional or at least won't-fix bugs.

        Both are not true for Rust.

    • cowlevel 5 hours ago

      As you can see, this is a true statement, but HN really really really hates it for some reason.

    • itishappy 2 hours ago

      Formal verification of the type system does seem a worthwhile goal, and to my understanding it's something the community has been making progress towards, but I also understand it's still relatively uncommon for most languages.

      Is this more an abstract concern over the state of the industry, or is there a specific language you had in mind that you'd prefer Rust was modeled after?

    • mirashii 2 hours ago

      Important to note that this is is not a bug in the type system itself, it's a bug in the borrow checker not enforcing invariants that the type system says that it should, and formal verification of the type system would not have helped here.

    • steelframe 58 minutes ago

      The font color is so close to the background now that I can't even read your edit. Sorry, bud.

  • codehero 4 hours ago

    "Type systems are hard!" As hard as its safety is pushed on us, not even Rust is free from hand waving.

    • ahartmetz 4 hours ago

      At least Rust has a chance to be largely correct because it has much greater effort per amount of code (in the compiler) invested into it than most any application code.

      • throwawayffffas 3 hours ago

        "Largely correct" my 2010 python 2 code is "largely correct".

        • ahartmetz 3 hours ago

          You are saying that there are only incorrect and mathematically proven with nothing meaningful in between?

          • AKrumbach 2 hours ago

            Not the grandparent you were replying to, but from the note added to the original linked issue (emphasis mine):

            > Rust's type system is *intended to prevent memory unsafety. Upholding this promise is something we take very seriously*, .... It is a large priority of the Types Team to *fix all type system unsoundnesses* and to work towards there being a solid foundation to minimize the risk of unknown ones.

            So, yes, if you have a group who "takes very seriously" the job to "fix all type system unsoundness", I would expect them to utilize some manner of formal proof verification that their type system is mathematically correct up to some defined limit.

          • hyperman1 2 hours ago

            Mathematically correct is not enough.

            Java's byte code verification algorithm had a proof. This was important for running untrusted java in the browser. If it said the byte code was ok, it was.

            Turns out, nobody made a proof for the verifier actually finishing. So it could return true, or false, or run longer than the universe has time. So around Java 6(?), someone wrote some bytecode that basically took forever to validate, DOSing the validator. Sun had to change the file format and add extra information to get the guarantees back.

          • throwawayffffas 2 hours ago

            No. I am saying you don't need rust for largely correct.

            PS: The term you are looking for is formally verified not mathematically proven.

            • throwawayffffas 2 hours ago

              Oh and btw their borrow checker is the kind of system that you would want formally verified.

        • mamcx 1 hour ago

          No, Python has not the level of "correct" that rust has.

          `sum(a:int, b:int)`

          not guaranteed ANYTHING.

          The gulf between how much correct Rust is and the vas majority of languages is HUGE.

    • caaqil 4 hours ago

      > not even Rust is free from hand waving.

      It is moral though, so who cares really.

    • doodpants 4 hours ago

      I mean, Rust's whole shtick is safety, so that's really the only thing there is to "push" about the language.

      • oersted 3 hours ago

        I wouldn’t say so… I consistently choose Rust mainly because it’s a sanely designed modern C++ alternative. It’s 20% more effort than writing Python or Typescript, and you get to use the full power of your hardware without compromise.

        Safety is a nice side-benefit. The main reason why I like the safety is because it allows you to fearlessly write high-level code without being constantly paranoid about memory as in C++. It’s more about enabling ergonomics without loosing performance, rather than security or correctness.

        • ryandrake 3 hours ago

          The paranoia about memory use in C++ should mostly be a thing of the past if you’re using smart pointers and sane patterns. In 2026 almost nobody should be calling new and delete and passing around raw pointers.

          • AlotOfReading 3 hours ago

            And yet applications written in modern C++ are constantly discovering new memory safety issues. Sean Baxter wrote a whole manifesto talking about the shortcomings of the existing C++ model [0].

            [0] https://safecpp.org/draft.html

            • bluGill 2 hours ago

              The problem with manefestos is they often harp on small parts that don't matter much in the big picture. There are real shortcoming of the C++ model, but if you use modern C++ they are rare.

              The real shortcoming it is very common for people to not write modern C++. I know several C++ developers who refuse to use smart pointers because they don't like magic happening.

              • AlotOfReading 2 hours ago

                It's not enough for memory safety issues to be "rare". To meet your obligations under the standard and have defined behavior (i.e. rust's basic guarantee), memory safety issues can't exist at all.

                • munk-a 1 hour ago

                  Ah, so this article invalidates all of the safety guarantees of rust? Since one hole was found the entire boat is shot and should be left at the bottom of the harbor?

                  C++ has a terrible reputation which is well associated with, say C++98, if you have a good linter you can bop people on the head for using news anywhere outside a few limited locations where you consider it warranted. All working environments have language features or even programming paradigms that are considered detrimental to code ecosystem health and fighting against these is an organizational lift when working in any programming language. Full type security doesn't mean someone can't create an overly generic object and just start breaking code contracts across the code base. C++ has an awful lot of footguns and more warts than most but it can be made to be sane for development and the new language features really bring it on par with other modern languages.

                  I have worked in C++ (primarily within the Qt framework which pushed hard into const refs instead of pointers) and it's fine. I've also worked in PHP which can also be fine. Rust isn't something I've worked at scale in but it certainly is very attractive if I ever jump to an org working in it - but even in Rust you'll want to restrict style divergence and bad patterns with linting.

                  • AlotOfReading 39 minutes ago

                    I'm only talking about modern C++, not C++98. C++'s footguns include smart pointers. For example, is the following code safe?

                        std::unique_ptr<int> p(foo());
                        std::print("{}\n", *p);
                    

                    The answer depends on how foo() is implemented. You can't reason about it locally, and strictly speaking it's not possible to determine at compile time. Now, I should be declaring this gsl::not_null<std::unique_ptr<int>> to comply with the core guidelines, but I think we can agree that optional support libraries aren't relevant to this discussion.

                • bluGill 12 minutes ago

                  Throw your computer away then. Rice's theorem and Godel's incompleteness theorem both make anything other than rare impossible.

                  These issues will exist for all time. The only question is how rare can we make them.

          • foldr 3 hours ago

            C++ still doesn't have a sane modern pattern for tagged unions. If you want to define a type to represent, say, a simple parse tree, then Rust makes that easy and obvious, whereas C++ offers you a hundred options, all of which suck.

            • sltkr 32 minutes ago

              Isn't the obvious choice std::variant<>?

              It is kind of annoying to use, but at least there is an obvious default choice.

          • bluGill 3 hours ago

            The reality though it many people are not using smart pointers. I have seen many people argue they don't like them because they want to see every place delete is called. (meanwhile of course they never notice all the places it should be called but isn't - but at least where it is they see it)

            • bayindirh 2 hours ago

              Personally I love to use smart pointers where bleeding edge performance is not necessary.

              If I need the absolute fastest code, then that code will be tortured under valgrind. That’s non-negotiable in my book.

              Code is not done until its memory management is proven correct.

            • thayne 2 hours ago

              It's more than that. Smart pointer help, but there are cases where even when using smart pointers you can encounter memory safety issues. Especially when you need to interact with c or older c++ code that doesn't use smart pointers. And smart pointers don't provide any protection against data races in multi-threaded code, like rust does.

              • LeSaucy 1 hour ago

                smart pointers solve a different problem than data races

        • cb321 2 hours ago

          Most things like "sanely" and "20%" are pretty subjective. To me writing (or really reading well written) Nim (https://nim-lang.org) is less effort than writing Python or Typescript. Nim is mostly Ada & Lisp ideas packaged in a more terse & flexible surface syntax. Nim also has nice compile-time introspection and very low effort macros to allow packaging near zero-code APIs like github.com/c-blake/cligen. Also, something like 5 out of 5 times I've investigated some Rust alternative to some Nim code, the Rust ran more slowly than my Nim on my tested CPUs.

          With access to inline asm, all speed is ultimately more a measure of effort applied than PLang. So those perf ideas are just "with my level of effort". Even Python via Cython has pretty direct access to asm. The "do it in pure X" that Sun popularized (even in a meta-/cross-PLang-sense) as a business attempt to define Java virtual machines as The platform has had many casualties, not the least of which is the quality of discussion of PLang practicalities, not just on HN, but everywhere.

          • oersted 2 hours ago

            I have heard great things about Nim, you may be very right. It’s just that it’s impossible to ignore the benefits of a mainstream dependency ecosystem. The ecosystem is exactly what made Python and Javascript the giants they are today, despite being somewhat mediocre languages. And the Rust ecosystem is in that same league, without giving up exceptional performance, and without giving up too much ergonomics.

            PS: I was very enthusiastic about Cython for a good while and I went deep into it, but I found that it is rather a mess to use in practice. Yes you get C performance within Python, kinda, but you also get all the C footguns, amplified by the complex interactions with Python features.

            • cb321 2 hours ago

              Yeah. Other ecosystems are undeniably larger than Nim's. I keep hearing about how LLMs are going to nullify that advantage with "not so sloppy" ports of anything to any PLang, but I've yet to see that pattern materialize. "What is a clean interface" is probably a kind of subjective judgement call, but also very clearly depends on PLangs and even PLang cultures. For example, the microdependency culture of Rust/JS/Node have very little to do with the PLang's themselves.

              EDIT: With Cython how I mostly kept things organized was the "caller allocation" so common in C where memory was always managed the usual mostly refcounting way of CPython/NumPy, but I had dozens (maybe even 100) little "kernels" I could pass that memory into that could even use Intel/MSFT "intrinsic" asm calls (things like immintrin.h) or even just #include C code which did similar. It didn't seem too bad to me, but Nim always seemed a more complete solution (at the PLang level - not counting ecosys). (And these days there is even NimPy (https://github.com/yglukhov/nimpy) to write low-level speed-up code for Python in Nim.)

          • thayne 2 hours ago

            There are a lot of nice things about nim, but it's absence of any kind of dynamic dispatch is a pretty serious limitation.

            • cb321 2 hours ago

              This is misinformation. There is (at least!): `method`, procedurally typed fields (inside case-object variants or not), run-time keyed `Table` with proc values, {.dynlib.}, importc/importcpp things. Beyond that, yes, Nim has rare compile-time superpowers that do lead many of its proponents to use static constructs (totally grant that!). So, you may not see a lot of dynamic dispatch in code bases, but there is little stopping you from using them in your own code.

              • thayne 1 hour ago

                Ah, yes, I should have been more precise. It doesn't have an equivalent of an interface/trait/protocol with dynamic dispatch.

                Yes, you can pass around an object of procedures, but that is awkward, doesn't have any support from the language or stdlib, and from what I can tell isn't a normal thing that is done.

                • cb321 1 hour ago

                  Even back in 2013 there were these ideas: https://forum.nim-lang.org/t/278

                  I think you & I are really back & forth-ing "the PLang not enforcing/strongly encouraging a very specific way of doing things that a whole ecosystem/community organizes around". Relying instead on self-organization has many pros & cons, to be sure. Lisp suffered much the same "until" Common Lisp (which still leaves many things open). My tag line lately is: delegation affords so much, but trust sure is tricky. Much of the time people seem to discount the often rather large cost of establishing/maintaining trust. (I'm not saying you are - just that it's an easy thing to do. I think it's why there is this is a big megathread on "trusting rust", even though "rust" is a veritable suffix of "trust". Lol.)

        • munk-a 1 hour ago

          > It’s 20% more effort than writing Python or Typescript

          I'd disagree with this point, there is more typing involved with a first draft of code than Python or Typescript, that's certainly true, but if we bring all the tools (e.g. docblock comments for "type declaration") that are habitual to make up for the shortcomings in most developer's minds then that gap shrinks and, imo, ends up swapping. It's cheaper to have automatically enforced and consistently maintained checks than moving that information out of band and the resulting code in a strictly typed and memory enforced language ends up removing a significant cognitive overhead when reading and maintaining the code.

          I have a strong aversion to boilerplate code so it's important to try and allow terse expressions when possible - but unstated assumptions are worse than overstated assumptions.

      • eloisius 3 hours ago

        Rust has a lot of things that make it nice to write in. Robust enums and pattern matching are something I miss greatly when I’m back in C++. The trait inheritance system is also very flexible and I miss that. Especially compared to monstrosities like multiple inheritance.

      • hackingonempty 3 hours ago

        Part of Rust's schtick is also cost free abstractions.

        • justinhj 2 hours ago

          Neither C++ nor Rust is zero cost in many cases. Rust needs unsafe or expensive runtime primitives for doubly linked lists, an lru cache, a tree with parent pointers... Both patch the language gaps with libraries.

      • airstrike 2 hours ago

        Only people who don't write Rust think Rust's whole shtick is safety.

        Consider reading past the hashtag.

      • nimih 2 hours ago

        Idk, it also has a nicely expressive typesystem outside of lifetimes, a lot of modern syntactic features like pattern matching and monadic error handling, well-written compiler error messages, a well-designed standard library, and substantially less accrued cruft when compared to its largest competitor. Safety might be the cudgel its evangelists like to beat everyone over the head with, but there are certainly things to recommend it outside of that.

    • antonvs 2 hours ago

      Rust’s type system enables the possibility of discovering and fixing a bug like this, and ruling out this class of bugs for all future programs.

      The hand-waving comes from other languages which can’t do anything to prevent their users encounter such bugs and the ensuing CVEs.

  • immmmmm 1 hour ago

    Aren’t some type systems (eg Lean) able to essentially verify/prove arbitrary mathematics?

    • kachnuv_ocasek 44 minutes ago

      Yes, until you introduce inconsistent axioms. Then you can prove anything.

  • oconnor663 1 hour ago

    https://github.com/JelleZijlstra/unsoundness is also a great collection of Python type system holes. In these cases, it's mostly deliberate design decisions, not bugs. The unfortunate fact is that a fully sound Python type system would be a pain to use.

    • metalliqaz 1 hour ago

      Perhaps I'm just an old dog that doesn't want to learn new tricks, but I still can't think of Python as typed and I never use type hints. I started with Python during the 2.3 era. I still view Python types as merely docs. So it's nice that someone tracks mypy quirks but I can't imagine relying on the results for anything serious.

      • ChrisSD 33 minutes ago

        To be very pedantic, Python was always strongly typed in the sense that every value has a concrete type. This is very different to, e.g. C, where `void*` is often used to actually erase the type or, conversely, more abstract languages where there are only interfaces.

        But of course Python function were always duck typed so it often didn't matter to the user.

        • eru 9 minutes ago

          Well, Python has a static type systems, it's just that everything has the same static type. We should call these 'unityped' languages, not 'untyped'.

      • oconnor663 30 minutes ago

        If you deal mainly with small-to-medium size Python programs, which is probably the norm, that makes sense to me. But if you have a large Python application, or if you own a library API that might have a lot of callers, typecheckers catch sooo many mistakes.

GrantMoyer 5 hours ago

It's surprising this bug went unnoticed for so long, but at least it's easy to fix, since it's not a bug with the type system itself; it's just a bug in the compiler. The compiler should always have been rejecting that code according to lifetime rules of Rust's type system, so the fix is to just make it reject the code, rather than having to change the fundamental rules of lifetimes.

  • mav65 4 hours ago

    Not knowing anything about rust, the problem in these type of case is making it rejecting that bad code without also rejecting valid programs. But maybe this is indeed easy to fix, I don't know.

    • bluGill 4 hours ago

      There are no such valid programs. Proof by contradiction:

      A valid program would be exploiting undefined behavior in rust, but rust has no undefined behavior. Thus such a program must not exist.

      Now a program may appear to work before the fix, but it was never a valid Rust program.

      • afdbcreid 4 hours ago

        I can't tell if you are sarcastic, but in case you are not:

        By Rice's theorem you cannot be sound and complete, i.e. accept all valid programs and reject all invalid ones. Most languages choose to be sound but not complete, i.e. reject all invalid programs but also some valid ones (C and C++ are the notable exception, although most languages have escape hatches). GP was saying that the fix might reject valid programs that compile today. This is true for some existing soundness bugs, but not necessarily for this one specifically.

        • bluGill 2 hours ago

          Rice's theorem does not apply. This is not about what the compiler does, it is your program. If your program is not sound then it is invalid Rust even if the compiler accepts it and it seems to do the right thing.

          That said, I was sarcastic.

          • afdbcreid 2 hours ago

            It does apply, of course (even if not to this case specifically). The implemented Rust semantics are not sound, as evidenced by this issue. We need to find (or adjust) sound semantics. Which, mathematically, is equivalent to designing Rust from scratch (ignoring things like RustBelt because they did not formalize the entire system). Due to Rice's theorem we know we need to give up some sound programs. Can we give up exactly the programs we already gave up for the previous Rust? Maybe, maybe not.

            • Someone 1 hour ago

              > The implemented Rust semantics are not sound, as evidenced by this issue. We need to find (or adjust) sound semantics.

              You’re ignoring the possibility that Rust semantics are sound, and the implementation doesn’t fully implement them. In that case, we do not have to find sound semantics.

              That, I think, by far is the most likely option.

              Reason: I’ve not seen a single comment claiming the example should compile, and zillions (implicitly) acknowledging this is not what Rust should do.

              • afdbcreid 48 minutes ago

                I explicitly did not ignore the option that there are possible sound semantics:

                > but not necessarily for this one specifically

                > Maybe, maybe not.

                But "the Rust semantics" are not defined, formally. The closest we have is what Rust implements currently, and that was shown here to not be sound. Other than that, we maybe have vague ideas in the brains of some T-types members, which are not detailed enough to determine soundness (source: those type system people want to formalize the semantics so they will be).

                And for the record, we know of other soundness issues where the likely resolution path will involve rejecting valid programs we accept now, and the only question is how many.

            • i2talics 1 hour ago

              The tricky thing about formalization is that you usually have to reimplement the type checker into a proof assistant in order to do formal soundness proofs. It's not necessarily clear that this reimplementation is identical to the actual Rust compiler (in fact, you often have to massively simplify the type system to make the proofs tractable), so bugs in implementation can cause unsoundness without being related to fundamental flaws in the soundness of the type system.

              • afdbcreid 46 minutes ago

                Indeed. Proving the implementation will likely never be done, it's just way too hard. But proving Rust abstract semantics are sound will by itself be a major leap forward (RustBelt did that for a subset of Rust).

            • Permik 1 hour ago

              It could be that I'm totally yapping bullshit, but the "designing from scratch" can vary depending which field of maths you're talking about. For instance, if we model the semantics as a series of composable functions, then you only have to scratch only the specific dependency tree of the functions. Basically everything can be reused with no wasted work, and the output space gets culled.

              • afdbcreid 47 minutes ago

                Which is why I said to ignore RustBelt. Because we don't have formal semantics today, we only have the actual implementation which is not composable.

          • i2talics 1 hour ago

            Terminological nitpick, but soundness is a property of an entire type system not of an individual program. A type system is sound if it only accepts valid programs. A program is valid if it never exhibits undefined behavior.

            Rice's theorem implies that it's impossible to precisely distinguish valid and invalid programs just by looking at their source code. Thus Rust rejects some valid programs in order to be sound (e.g. "if false { None.unwrap_unchecked() }").

            In the case of the bug report in OP, I don't think that there are many valid programs in practice that exploit this soundness issue, so fixing it just means rejecting more invalid programs.

        • charcircuit 2 hours ago

          Rust does not target Turing machines so Rice's theorem does not apply.

    • foldr 3 hours ago

      In this case the issue is that the compiler just isn't properly type checking the implicit call to the drop method that's inserted at the end of the nested block. AFAIK, no correct code should depend on the absence of that check.

  • WiSaGaN 4 hours ago

    It's fascinating that this kind of bug is exactly you can't really avoid even when rust is supposedly to guard against. Rust mitigated this problem a lot in practice, but you can never be certain because of issues like this in practice. This is similar that a math proof that's already been peer reviewed and accepted as truth, may still be possible to be wrong, although the chance is very small but it's not zero. Epseicially when the complexity gets higher.

    • Garlef 3 hours ago

      ... and even if you formalize it, it could still be false due to an error in the theorem prover itself.

      • GrantMoyer 2 hours ago

        And even if the theorem prover has no errors, the math behind the theorem prover could be inconsistent according to Gödel's incompleteness theorem. So even in principle, we can never be completely certain about the soundness of Rust, though the more theoretical concerns tend to be dwarfed by basic human error.

        I think it's a good thing to keep in mind, that the actual implementation of Rust almost certainly isn't sound. Even an "ideal Rust" still has unsafe, which can affect the soundness of even faraway safe code. But I don't think it's nessesarily wrong to talk about Rust as if it were safe. Much of our communication has implicit assumptions, and the way we talk about Rust is no different. It would be exhausting to qualify every discussion of saftey with "assuming the compiler has no bugs", "assuming all unsafe code follows the (not fully specified!) rules", etc.

        Ultimately it's like any other implementation of theory into practice. The theoretical model of Rust lets us reason about and design an implementation to achieve certain practical goals even though the model is a simplification of reality. In Rust's case, practical use has demonstrated it achieves design goals like reducing bugs and reducing development time (compared to peers like C++) to a substantial degree.

weinzierl 5 hours ago

This is remarkable but not super unusual. There are more than 100 issues labeled unsound currently. Some are long standing but from what I understand the new trait solver will unblock fixes for some of them (but probably not the one in OP).

  • theemathas 5 hours ago

    Finding unsoundness bugs isn't the most unusual, yes. But this one is unusual in how simple the code that causes it can be (see the versions of the reproducer code in the comments). For other unsoundness bugs, the code would need to contort itself a lot to avoid the compiler checks.

lambdaone 6 hours ago

Perhaps ironically, AI-based searching of the Rust compiler for bugs is likely to find more of these, pushing Rust closer and closer to the point of complete reliability.

The eventual formalization of Rust and a creation of a formally proven compiler is presumably going to be the end point of this process.

  • kimi 5 hours ago

    Or we realize that it is not possible, and Rust accepts to be "just" a definitely safer C.

    • wongarsu 5 hours ago

      There is a formally proven compiler for a large subset of C, so I don't see why formalizing (a large subset of) rust and making a formally proven compiler shouldn't be possible

      • UncleMeat 5 hours ago

        Because people want a performant optimizing compiler.

      • afdbcreid 5 hours ago

        There is a severe misunderstanding here. Beside being only a subset, CompCert definitely has UB. It just formalizes codegen for codebases not containing UB, which obviously won't be enough for Rust.

      • afdbcreid 5 hours ago

        Also unlike C, it should be possible to formalize all of Rust, not just a subset. For two reasons: Rust evolution (not initially but today) is strongly tied with formalizing it and the language team consults with formalization experts (which are part of the Rust project themselves) all the time (and formalization or semi-formalization projects are ongoing), and also the mathematical understanding of system languages itself has advanced.

        • j16sdiz 4 hours ago

          This reminds me of Hilbert’s Program .

  • stingraycharles 5 hours ago

    Why would that be ironic? AI is helping us find so many subtle bugs and isolate the root cause, it’s nearly perfect for this type of use case.

  • mi_lk 5 hours ago

    What aspects of it are remotely ironic?

    • brzz 5 hours ago

      Hey, if Alanis Morissette can make the same mistake…

    • jere 4 hours ago

      Obviously, many people have viewed AI’s contribution to programming as just producing unreliable garbage.

      Yes, that’s an incomplete and tenuous belief, but that’s where the irony is. If you’re omniscient you don’t get to experience irony.

    • antonvs 2 hours ago

      “Slop generator makes all future programs more reliable”

      • sanderjd 1 hour ago

        Yeah this is actually quite interesting. I can see how people who have this "slop generator" perspective on AI would see this as an irony. But to me, it isn't an irony, it's a demonstration of why this perspective on AI is wrong.

  • malkia 5 hours ago

    and what stops AI from "accidentally" writing code with such bugs?

    • hbn 4 hours ago

      Code review and testing? As always?

      • bcjdjsndon 3 hours ago

        If you could be trusted to do that, we wouldn't need rust in the first place....

        The basic contradiction of the rust fad, coders can't be trusted to be memory safe so those same coders must use rust and then all of sudden they can be trusted not to make common mistakes. And before some tart steps in to bring up safe rust, you're missing my point entirely

        • jason_oster 1 hour ago

          Even if you could be trusted to do that, we still need languages like Rust and tools like ASAN and Valgrind. Trust but verify. Trust alone is not enough.

    • antonvs 2 hours ago

      The compiler. That’s the whole point here. Type systems can prove the absence of entire classes of bugs, at compile time. If AI identifies bugs in type systems that can be corrected, then all future programs benefit, including those written by AI.

  • lifeisloving 5 hours ago

    I asked myself, How many comments to do I have to collapse before someone says something about AI. 3.

    I used to compare this hype to crypto hype, but its so much worse. Can we just try not to shove llms into every single conversation.

    Is there a hackernews type space where the word is banned? Even lobste.rs has this problem. I need some sort or way to just hide all content on certain sites where LLMs/AI are mentioned.

    • streetfighter64 4 hours ago

      I'm not a huge AI hype man, but I think you'll just have to accept it. It's a new useful tool, of course people are excited to apply it to everything.

      Like it or not, programming will become largely LLMs. And the comment you're replying to is actually making a pretty good case for where the use of LLMs is good: generating code to be formally verified.

      • lifeisloving 3 hours ago

        Something something halting problem. I never said don't use the tool!! I use the tool too! I just dont want to talk/read about it all the time.

        Programming will never be dead.

        1. Because the situation you describe is fantasy.

        2. Even if it is a reality and all software can be verified (it cant), I will still be programming and so will millions of others because its fun, programming and sex are really damn close to things I cant live without. Not everyone got into engineering for the money. I legitimately love this activity, it is my actual passion. I would rather be poor than give it up.

        Its like im being told everyday all day, non stop that the thing I love is not worth loving.

        • SV_BubbleTime 3 hours ago

          I guess that’s something you need to work through that you’re just so sick of reading about the single biggest evolution in technology since the internet :(

          Maybe tech isn’t for you if you don’t like trying to stay on top of it.

          • lifeisloving 3 hours ago

            Huh...

            Anyways, I probably know more about llms than you, I probably use them more than you. I just dont want to turn every conversation into a discussion about them.

            I would argue the smartphone is 1000x more impactful than LLMs, along with many other inventions since the internet. I'm not really sure what contribution llms have had that are actually THAT impactful for peoples lives. Its possibly (but unlikely) a net negative, time will tell. Most people using them are not getting smarter, thats concerning. Most are just making more money for their bosses who are itching to replace them with an llm.

        • wanderlust123 2 hours ago

          This seems more like you projecting what you want in terms of what you enjoy and hoping the world optimises around that preference.

          The truth is LLMs is what you need to be optimising around as they will become the standard.

          • 1sh172645 2 hours ago

            Why don't you start TruthLLM like Trump started TruthSocial?

        • 1sh172645 2 hours ago

          You need to bow in the direction of Silicon Valley every three hours or the inquisition comes.

        • samus 1 hour ago

          Of course people will still program for the foreseeable future. But it is still a legit question how long it will be before people come to accept a vibe coded program and are ready to deal with its flaws (of course with more vibe coding) compared to hiring a consultancy.

          I'm not talking about mission critical software, but bespoke business applications that are produced by software engineering sweatshops and where the actual users are inured to incomplete features with sharp edges, arcane bugs, and incomprehensibly long intervals between bug report and fix.

          Even in mission critical software we will likely see a lot of LLM tool usage. Even if the copyright plug is pulled and all vibecoded applications are regarded as copyright violations, its uses to analyze existing code and give advice will remain. In this world, writing applications entirely by hand will become an artisanal discipline.

      • 1sh172645 2 hours ago

        Thank you for citing the Anthropic propaganda manual!

    • purplesyringa 2 hours ago

      lobste.rs has a `vibecoding` tag that you can hide.

  • groundzeros2015 3 hours ago

    > complete reliability.

    I think that’s a myth! What tends to happen in mature software is there are unfixable tradeoffs that can be made that favor one use case or another. And of course people will keep adding features too

    • dymk 2 hours ago

      That’s why they said “closer”

    • vips7L 24 minutes ago

      Just wait until someone relies on that bug too.

Eridrus 3 hours ago

I feel like these things get waved around as gotchas without any sense for whether any real code is impacted.

It will be interesting to see if fixing this bug actually causes any crates to not compile.

  • Falell 3 hours ago

    We should know shortly, the PR to fix this will presumably be paired a crater run, a build of the entire public crates universe.

Surac 4 hours ago

The question is. If rust used rust would that have prevented this?

  • zamalek 2 hours ago

    Rust does not prevent all bugs, only certain ones (that are common and dangerous).

  • loa_in_ 1 hour ago

    Rust allows for type-proofing your logic, but it can't force you to.

gosen 4 hours ago

I'm sure we'll get more of those on other languages / frameworks too. I tend to believe that it's for good

FuzzywarmWalnut 6 hours ago

Worked on a variance-related lint once and the scary part is how rarely anyone writes down variance by hand, so bugs there just sit untested for a decade.

  • afdbcreid 4 hours ago

    Nobody writes variance at hand in Rust because it's impossible (since before 1.0). You sometimes need to enforce stricter variance than the default (can cause unsoundness and is very subtle but actual unsoundness here is rare) or give more permissive variance (harder and also cannot cause unsoundness, just annoyance).

    When implementing the type system, however, variance does have to be treated with care. Historically it wasn't much, now it is.

sreekanth850 1 hour ago

Was this done by LLM? this is a doubt. because recently we are seeing many such bug reports.

randyrand 4 hours ago

I just wish Rust handled out of memory more gracefully like a normal error.

  • bluGill 4 hours ago

    Why bother? Most systems these days have over commit and so you can never get an out of memory error. The OS will happily give you more and more RAM, and then when you try to use that memory kill a program (may or not be your program). The only out of memory error you can see is if you are trying to allocate more memory than the address space allows. This is so unlikely that nobody considers it worth bother to try to handle.

    • JoshTriplett 3 hours ago

      It is important to try, for a few reasons. Among other things, increasing amounts of Rust written in the Linux kernel itself, and other environments where you need to take more care with memory allocation.

      Rust as a language is capable of that. If you don't use the standard library then you can provide that functionality yourself. The standard library is trying to support it, without creating interfaces that are a massive pain to use.

      For instance, it's easy for us to support `Vec::try_reserve`, and we do, but that's not trivial for users to use everywhere; it's error-prone, and it's easy to make a mistake and call a method that goes past your reservation. It's painful for us and for users to make `Vec::push` support this (and having a `try_` variant for every function), so we've been working on a better solution. One current possibility is to have a dedicated type for a Vec that has OOM handling, where `push` can return an error, so you know if you use that type you can never accidentally fail to handle OOM.

  • efficax 3 hours ago

    the biggest design wart of rust (well one of them) is that support for custom allocators wasn't built into the type system from the start, with allocation osmething that returns Result

wat10000 3 hours ago

The emotional reactions to this stuff are so weird. Yeah, software has bugs, what a surprise. That doesn't mean that static safety is useless or that we should all just continue YOLOing stuff in C.

  • bcjdjsndon 3 hours ago

    Rust is a cult, the definition of an emotional reaction.

    Remember when try catch exceptions were invented and people said coders can no longer ignore errors? How many empty try/catch blocks exist on code today?

    Rust doesn't really solve any of the UB in C, and just marks it as "unsafe".... We're back to square one

    • loa_in_ 1 hour ago

      You can iterate through all unsafe sections of the codebase by simply grepping for `unsafe`, the rules are followed everywhere else. It's a great improvement.

    • samus 1 hour ago

      That's not how "unsafe" works at all. If "unsafe" is so commonplace in a code base that your statement becomes relevant then the project is badly run, and memory safety is just another problem among many others. Similar to accepting code with empty or nonsensical `catch` blocks.

    • benjaminkiefl 31 minutes ago

      As always the same tropes get repeated ad nauseam.

      Rust code using `unsafe` != C code:

      -) you can encapsulate `unsafe` internals behind safe interfaces

      -) you can concentrate operations requiring manual safety reasoning in small parts of the codebase

      -) safety obligations become explicit

      -) `unsafe` does not turn off the borrow checker, type checking, ordinary bounds checks, or automatic cleanup and you still benefit from Rust's provided abstractions and its composability

      I'm not a Rust shill, and not a single programming language I use is part of my online identity, but if "Rust is a cult", the anti-Rust gang isn't?

      Getting more and more annoyed by the latter to be honest.

      • wat10000 13 minutes ago

        Yeah, I'm always told that the Rust community is obnoxious and condescending. But I never actually see it. I do see a bunch of obnoxious anti-Rusters show up every time Rust gets mentioned to complain about it.

        Also not a Rust shill, I used it for a few months about a decade ago. I am a memory-safe-programming-languages shill, though. I know there are good reasons people still use C-family languages (and I'm often one of them) but we should definitely be doing our best to move off them as quickly as we reasonably can.

cheney_2004 4 hours ago

I think one social issue I’m seeing is that the Rust community bashes other languages for safety but then glosses over or even completely ignores their own safety risks (see supply chain). I would rather see Rust focus on its actual features without bashing others and maybe start moving away from claiming the gold metal on security. Being less toxic is always a good thing for long term health.

  • gchamonlive 3 hours ago

    It's important to separate the community ethos and the rust core dev team policies, because I'd be surprised if the official stance of the rust team would be condescending to other technologies.

    • SV_BubbleTime 3 hours ago

      Have you met humans?

      I’d be shocked if people working on and passionate about thing didn’t shit on other thing. That’s natural and even good in moderation. It’s up to a leader to keep it under control.

      • mcherm 3 hours ago

        Yes. In fact, I have met quite a few humans who make a point NOT to go bashing the work of others. (Of course, I have also met quite a few who do spend their time bashing others.)

      • tehjoker 1 hour ago

        The more you understand about your own system the more humility one would think you would have. This is like the dumb guy to jedi meme. It's the people in the middle that shit on other peoples' work because they have something to gain by looking comparatively smarter.

    • the__alchemist 1 hour ago

      Rust is my favorite language in most domains I program in; I've learned to ignore the online rust OSS community due to a mix of preferring heavy abstractions (then shaming your code if you don't use them), and rude behavior.

      This is fine, for the reasons you state: I can use the language and tools while ignoring the jerks.

  • ModernMech 3 hours ago

    Can you give an example of this toxic bashing from rust contributors or are you talking about just random HN posters when you say “rust community”?

    Moreover, I wouldn’t say they’re completely ignoring supply chain risks, as there have been discussions about this as early as 2021 [1] and there are ongoing efforts to address this [2]

    [1] https://internals.rust-lang.org/t/about-supply-chain-attacks...

    [2] https://kerkour.com/fixing-rust-supply-chain-security

    • lifeisloving 3 hours ago

      Yeah Ive actually never seen any Rust team members be toxic. Keep in mind there is a micro niche of tech influencers who try to politicize rust because they associate it with liberalism or something like that and paint Rust community as an opposing force to some status quo they think exists or should exist. Those notions have taken on a life of their own.

      People who say this just dont know what they're talking about and are repeating youtubers and X takes.

    • bcjdjsndon 3 hours ago

      There's a fanaticism amongst Rust devs that borders on a cult. They even described their thinking as such, unironically.

      Even the basic logic is flawed.... That coders can't be trusted to handle pointers, but somehow can be trusted to write "safe" unsafe rust.

      • cmrdporcupine 1 hour ago

        The only fanaticism I'm seeing here is you going through the entire thread and picking fights and calling people who use and advocate a language names.

        "fans" "fanatics" "cult"

        I'm not sure what the point of this way of talking is. Rust is a tool. Many advocate for it because we've worked for a long time in ... other tools. Which had avoidable problems. I had a two decade career with C++ before Rust finally became mainstream enough to get paid to work in. Going back here and there is usually... unpleasant.

      • dabinat 48 minutes ago

        > Even the basic logic is flawed.... That coders can't be trusted to handle pointers, but somehow can be trusted to write "safe" unsafe rust.

        Who said anything about trust? The purpose of unsafe blocks is that you have specific, limited areas of your code that can be audited for safety. With C your entire codebase needs to be audited.

        Also, other languages “trusting” people to use pointers correctly has gone pretty badly.

  • zamalek 2 hours ago

    > being less toxic

    There's a difference between people you disagree with and toxic behavior. Can you give examples of toxic behavior?

  • slopinthebag 5 minutes ago

    the only thing more exhausting than rust evangelism is people who drop in on any rust related thread and start whining about unrelated things just because it's rust.

j4k0bfr 6 hours ago

Took me a good couple minutes to wrap my head around. Man, what a nasty bug. I guess this specific use-case is rare. Time to see if any of the big libs are affected...

  • coliveira 5 hours ago

    A nasty and rare bug can and will be exploited once it is found. The only thing necessary is for malicious actors to start adding this case in innocent looking code and there you have.

    • afdbcreid 5 hours ago

      That's a misunderstanding. This is not a security vulnerability and Rust explicitly does not defend from malicious programs, only from mistakes. This bug however is quite dangerous, because unlike many soundness bugs it seems plausible to hit by mistake.

      • Liquid_Fire 3 hours ago

        > it seems plausible to hit by mistake

        The report seems to claim the opposite:

        > Looking at the bug itself, it is also very likely that this unsoundness has not caused memory unsafety by accident. While it looks easy to trigger, to exploit this you need an intentionally malicious Drop implementation.

        • afdbcreid 3 hours ago

          This edit is newer than my comment (and its writer is an experienced T-types member, so I take back my words).

MrBuddyCasino 6 hours ago

The heart of the matter:

  struct Q<T: 'static>(Option<T>);

  impl<T: 'static> Drop for Q<T> {
    fn drop(&mut self) {
        // Code in here has access to a non-'static &String
        // but assumes that it's a &'static String
    }
  }

  fn main() {
    let l = String::new();
    let mut q = Q(None);
    q.0 = Some(&l);
  }

I wonder if the certified compiler for safety critical uses (edit: Ferrocene) has the same issue.

  • wg0 6 hours ago

    DeepSeek v4.1 Flash thinks it should NOT compile. Whereas in reality it DOES compile which is why it is filed as a bug.

    • jug 6 hours ago

      They're seriously using AI as a judge for what to file?

      • afdbcreid 6 hours ago

        The issue and none of the comments mention AI. It is pretty clear your parent said it by themselves.

      • wg0 6 hours ago

        I was just checking what outcome an LLM would have based on the patterns in its probabilistic distribution it has seen the wild.

        Most LLMs would probably say this piece of code won't compile.

        • ChickeNES 5 hours ago

          chatgpt and grok linked to the the soundness issue, claude I am in usage timeout, and gemini shit the bed as usual: "The compiler rejects the program with error[E0597] on the assignment q.0 = Some(&l)"

  • afdbcreid 6 hours ago

    > I wonder if the certified compiler for safety critical uses has the same issue.

    It uses the same code, so yes.

    (Although I don't know what are their guidelines, it might be that they require avoiding code relying on implied bounds, for example).

  • 1718627440 5 hours ago

    Can someone ELI5 for people who don't know Rust (but e.g. C)?

    • thinkharderdev 5 hours ago

      Rust is supposed to guarantee statically that a reference cannot outlive its referent. The `T: 'static` bound means that the value that Q holds must have a 'static lifetime (e.g. either be an owned value or a reference to a static value). So this program should not compile since a reference to l is not 'static. This code is unsound because rust will drop the string l before q so when the Q destructor runs the underlying string has already been freed yet we have a valid reference to it.

      • 1718627440 5 hours ago

        What does "q.0" and "Some(...)" mean?

        • bonzini 5 hours ago

          "Some(...)" means that this Option<T> does have a value of type T in it; "None" means it doesn't.

          "q.0" is not really needed, it's a struct with unnamed fields. Here is the same with named fields:

            struct Q<T: 'static> { pub x: Option<T> }
            ...
            let l = String::new();
            let mut q = Q { x: None };
            q.x = Some(&l);
        • cowlevel 5 hours ago

          Some(...) is just constructor for an option type as seen in other languages e.g. java's Optional, haskell's Maybe, c++'s std::optional. I assume that it's needed here because the field can't start as a null pointer otherwise. Maybe the vulnerability still works if the field starts with one string value and swaps to a different string value, but having it start holding None made for a simpler demo.

          q.0 is the first field of q, which is anonymous. They could have just as well called it x and written q.x.

        • thinkharderdev 5 hours ago

          So Q is a "tuple-struct". In rust you can define a struct like

          struct Q<T> { value: Option<T> }

          with a named field or you can define it like

          struct<T> Q(Some<T>)

          which is the same struct layout but without an explicit name for the value. In that case, the field is implicitly names `0`

          So q.0 = Some(foo) is equivalent to q.value = Some(foo).

          The Some(..) is just one variant of the Option enum:

          enum Option<T> { None, Some(T) }

          Option represents a value that may or may not be initialized. For uninitialized values you use the None variant and then you can initialize it to Some(value).

          The C rough equivalent would be

          struct Q { void* value; }

          struct Q q = q { NULL }; q->value = ...

      • 1718627440 4 hours ago

        So the equivalent in C would be:

                $ cat main.c
                #include <stdlib.h>
                #include <string.h>
        
                struct Q {
                        /*@null@*/ /*@only@*/ char * t;
                };
        
        
                /*@only@*/
                struct Q *
                Q_new (/*@only@*/ char * t)
                {
                        struct Q * q = malloc (sizeof *q);
                        q->t = t;
                        return q;
                }
        
                void
                Q_set (struct Q * q, /*@only@*/ char * t)
                {
                        free (q->t);
                        q->t = t;
                        return;
                }
        
                void
                Q_free (/*@only@*/ struct Q * q)
                {
                        free (q->t);
                        free (q);
                        return;
                }
        
        
        
                int
                main (void)
                {
                        /*@only@*/ char * l;
                        /*@only@*/ struct Q * q;
        
                        l = strdup ("");
                        q = Q_new (NULL);
        
                        Q_set (q, l);
                        free (l);
        
                        /* This is UB */
                        Q_free (q);
        
                        return EXIT_SUCCESS;
                }
        
                $ splint main.c
                Splint 3.1.2 --- 21 Feb 2021
        
                main.c: (in function Q_new)
                main.c:15:3: Arrow access from possibly null pointer q: q->t
                  A possibly null pointer is dereferenced.  Value is either the result of a
                  function which may return null (in which case, code should check it is not
                  null), or a global, parameter or structure field declared with the null
                  qualifier. (Use -nullderef to inhibit warning)
                   main.c:14:17: Storage q may become null
                main.c: (in function main)
                main.c:43:6: Unrecognized identifier: strdup
                  Identifier used in code has not been declared. (Use -unrecog to inhibit
                  warning)
                main.c:44:13: Null storage passed as non-null param: Q_new (NULL)
                  A possibly null pointer is passed as a parameter corresponding to a formal
                  parameter with no /*@null@*/ annotation.  If NULL may be used for this
                  parameter, add a /*@null@*/ annotation to the function parameter declaration.
                  (Use -nullpass to inhibit warning)
                main.c:47:8: Dead storage l passed as out parameter to free: l
                  Memory is used after it has been released (either by passing as an only param
                  or assigning to an only global). (Use -usereleased to inhibit warning)
                   main.c:46:12: Storage l released
                main.c:12:1: Function exported but not used outside main: Q_new
                  A declaration is exported, but not used outside this module. Declaration can
                  use static qualifier. (Use -exportlocal to inhibit warning)
                   main.c:17:1: Definition of Q_new
                main.c:20:1: Function exported but not used outside main: Q_set
                   main.c:25:1: Definition of Q_set
                main.c:28:1: Function exported but not used outside main: Q_free
                   main.c:33:1: Definition of Q_free
        
                Finished checking --- 7 code warnings
        

        (The equivalent warning is main.c:47)

        • NobodyNada 3 hours ago

          If you wrote a Q_free function and called it after `free(l);` to actually demonstrate the UAF, that would be pretty close to the semantics of the Rust example.

          • 1718627440 3 hours ago

            I have added that now.

            I originally didn't do this, because I didn't feel the need to invoke UB without necessity. Also I wanted to demonstrate, that the error can (and is) caught in C, without actually committing the double-free (so that the program behaviour is still well-defined, but the abstraction is already violated).

            • NobodyNada 2 hours ago

              I'm not familiar with Splint, but my understanding is that the error is because of the @only@ marker indicating that the string is not shared. That's an incorrect translation of the Rust program, where the reference to the string is explicitly a shared reference rather than an owned reference. The issue isn't the sharing; it's that rustc mistakenly allows the code to assign a reference that is valid until the end of the current scope to a field that expects a reference valid forever (like a string constant in the program binary). The Rust program with equivalent semantics to your C program (passing an owned String instead of a shared reference) is correctly rejected by the compiler.

              Also, the Q_free function should not free q->t. It may access it (e.g. printing it), but it does not own that reference and is not responsible for deallocating its memory.

              Sorry, I should have looked closer the first time! My excuse is that it was too early in the morning to be thinking about such things.

              • 1718627440 2 hours ago

                Yes, @only@ means that the parameter/variable is owning. I believed that would have been the meaning in Rust. Now I can no longer edit my comment, oh well.

                > Also, the Q_free function should not free q->t.

                Well, that's because I thought it would own it. But if in Rust it is not implied that the Q owns the string, then I fail to see where the error is? Both l and q will be deallocated at the end of the main function. Depending on the order of the deallocation maybe q exists for a theoretical time while pointing to already deallocated memory. But both get deallocated at the same point, so q does not outlive the existence of l, so where is the error?

                • NobodyNada 2 hours ago

                  The error is the destructor of `q` could look at the reference and stash it away somewhere, like a global variable (since the compiler thinks the reference is valid forever). Then, some other part of the program could access that variable and cause a UAF.

      • biorach 3 hours ago

        > rust will drop the string l before q

        Why?

        • 1718627440 3 hours ago

          My thoughts as well. The problem can be alleviated either by making the ownership change an error or "just" invoking the destructors in the correct order.

          But I think https://news.ycombinator.com/item?id=50072252 answers it:

              A 'static lifetime constraint on T says: types that satisfy T must not contain any borrowed value/content whose lifetime will be shorter than the life of the program. 
          

          So the compiler assumes it is guaranteed, that 'l' still exists, so it doesn't consider it in regard of finalizer ordering.

        • NobodyNada 2 hours ago

          That's incorrect; the compiler drops q before l. Drops happen in LIFO order; and the compiler knows that it can't drop l before q has been dropped, because q contains a reference to l.

          The issue is that the destructor of q can observe a reference which is about to be deallocated as having a 'static lifetime (i.e. it will live forever), and can thus stash it away somewhere for other code to access after it's been freed (as in the examples in the issue which demonstrate UB.)

    • efficax 3 hours ago

      'static lifetime bounds are kind of confusing in Rust, but here goes: A 'static lifetime constraint on T says: types that satisfy T must not contain any borrowed value/content whose lifetime will be shorter than the life of the program. So suppose you have a string s, and Option<&String> q. If q has the constraint 'static, and you do q = Some(&s) this should be rejected by the compiler since a reference to s gets a shorter lifetime than 'static by default (you could do q = Some(&'static s) if s is say a string literal or a leaked box but not for a normal string). In the examples it looks like you have to use a tuple to trick the borrow checker but the concept is the same: Rust allowed violation of the 'static lifetime bounds. The drop implemenation demonstrates it: drop happens in reverse declaration order, so the string s gets dropped first. Now q has a dangling reference, a pointer to dropped memory essentially, and we get a pretty classic use after free bug.

vincent-uden 6 hours ago

What the hell. This is not the esoteric, crazy, impractical constellation I expected to find with a title like this. The minimal example is so simple and is definitely something you'd easily come across in normal code.

  • LoganDark 6 hours ago

    I wonder if the reason it works is because you'd easily come across it in normal code, and someone didn't realize that saving the effort of implementing a check for this would result in unsoundness.

    • afdbcreid 4 hours ago

      That's not how it works. rustc doesn't "check" for specific cases explicitly, the borrow checker (apparently at fault here by reports) has a set of rules that should reject invalid programs. So either one of the fundamental rules was broken (unlikely here from what I've heard), or some optimization caused the rules to not be implemented correctly.

  • jvanderbot 6 hours ago

    Not really. I've worked with rust for 4 years, systems side, and never had to write a custom drop implementation. That's the gotcha here, not the rigamarole with the static+Send option type (which _would_ be something you'd encounter in prod).

    • bryanlarsen 6 hours ago

      I've written dozens of custom Drop implementations. Well, many of them are named cleanup because of the async Drop mess in Rust, but...

      • dwattttt 5 hours ago

        How many of them only conditionally implement Drop, based on a generic param lifetime?

        • Xirdus 5 hours ago

          Why would you ever conditionally custom impl Drop? I don't think I've ever seen that pattern, and I can't think of a use case.

          • jason_oster 53 minutes ago

            Therefore explaining why the bug hadn't been hit in practice for 11 years.

      • jvanderbot 5 hours ago

        OK. That's good to know. I'm not sure why sharing our professional experience with this type of code is controversial, but here we are.

    • neysofu 6 hours ago

      That's easily the exception rather than the rule. I've seen custom `Drop` implementations in almost every non-trivial Rust codebase I worked on.

    • gspr 6 hours ago

      A custom `Drop` appears very quickly with FFI code. Suppose for example you interface with some C library that expects you to call a function to release some resources.

    • rvz 5 hours ago

      Now we are at the phase where, Rust is “safe” but only if you use it “correctly” and without using X language feature or a custom Y feature.

      This is the problem when a language advertises with “guarantees” and it turns out it never had any due to many false assumptions by their promoters.

      So what other soundness bugs are there in the language that we need to know about?

      • jvanderbot 5 hours ago

        I'm not defending rust here - a correctness bug invalidates the premise. But I am saying that I've never seen a custom drop in production.

        For some reason this is controversial, but it remains true.

        • cmrdporcupine 5 hours ago

          Custom drops are all over the place. As others have said.

          But not custom drops that are doing variadic type stuff like this, usually.

        • bryanlarsen 5 hours ago

          You said/implied 2 things:

          - you've never written a custom Drop

          - "Not really". Implying that your experience generalizes

          I've written a bunch of rust programs without custom Drop. I believe your first statement. There are large classes of programs that don't need it. There are also many that do. I think your statement says a lot more about what kind of programs you work on than about custom Drop not being common. People are downvoting the implication that custom Drop is not a common pattern.

      • cmrdporcupine 5 hours ago

        No we're in a situation where a bug in the type checker was found and will be fixed and a new release will be made.

        That it took 11 years for someone to come across this is a fairly intense counterargument to your attempt to paint this as a language with dangerous footguns.

  • insanitybit 6 hours ago

    For a long time `loop {}` was undefined behavior. Lots of l-unsounds are really nuts but a few are not.

    The reality is that if this were actually code that people wrote, well, it wouldn't have sat around for a decade.

  • fg137 5 hours ago

    > is definitely something you'd easily come across in normal code.

    The fact that nobody reported this before means it's not, by definition.

    • vincent-uden 4 hours ago

      Not at all. There are way more valid lifetimes than the lifetime system of Rust can express. There are countless scenarios where you could accidentally use the unsound behaviour while not producing a segmentation fault because the lifetimes happens to be arranged such that no invalid memory access actually happened.

      A program isn't invalid just because it violates the ownership and borrowing rules of Rust. There are tons of programs in the world with shared, mutable access, devoid of Mutexes, Arcs and Locks that nonetheless are completely valid.

      • fg137 4 hours ago

        I think you are talking about a different problem and that has nothing to do with my comment.

        • foldr 3 hours ago

          Simplified, the point is that a lot of badly typed code that this bug lets through might be mostly harmless (or even fully semantically correct, in some instances). So you can't conclude that 'normal' code wouldn't trigger this bug just because no-one's noticed it until now. The bad code could could be happily executing and performing as expected.

badatnames 6 hours ago

There is a collection of these someplace. Rust is better but it'll never be perfect, news at 10

  • zer00eyz 6 hours ago

    Rust is good, I generally do not dislike it - but it does have flaws.

    I will happily continue to write things in Golang first. I don't enjoy refactors in Rust, and it's rare that I see things that genuinely need its raw performance.

    Cloudflare's Oxy is a stellar example of build in Golang till your design is settled and then port over for performance when you need it.

rurban 4 hours ago

And a fork fixed it before upstream rust :)

  • Groxx 2 hours ago

    ...yes? that's usually the case in open source software.

Hugsbox 6 hours ago

I don't understand how something like this could take so long to be discovered. Pretty crazy stuff.

  • lelanthran 6 hours ago

    > I don't understand how something like this could take so long to be discovered.

    Maybe they wrote it in C :-)

    On a serious note, old software is generally more trustworthy than new software, because bugs are discovered over time and with usage.

    • zaphar 6 hours ago

      Old C software is generally more trustworthy than new C software. I don't think this rule of thumb transfers across languages very well. And the definition of new vs old has a fairly large effect. If a language has been under constant change it doesn't matter when it was started a large part of the codebase is "new".

    • dabinat 1 hour ago

      > On a serious note, old software is generally more trustworthy than new software, because bugs are discovered over time and with usage.

      The age of software means bugs are more likely to be discovered but not necessarily fixed. In the case of Rust, the developers have documented a whole lot of unsoundness bugs that require a new borrow checker architecture to fix.

  • fg137 5 hours ago

    Because it's rarely used like this, just like weird bugs caused by edge cases found in all kinds of software in the world.

fnord77 5 hours ago

Here's the weakness of compiled programs. Does this compiled code have this vulnerability? You have no idea. At least with a VM or interpreter you can scan for vulnerable versions and replace the runtime or the specific library.

With this you have to recompile everything

  • baq 5 hours ago

    That is less and less true by the day, for better or worse.

  • cowlevel 5 hours ago

    It's possible to scan compiled programs at the assembly or machine code level. Not enough people do, which is fair enough because it's a slog, but it makes all compiler UB transparent to the analysis.

z3ratul163071 5 hours ago

so now what? back to c++?

  • medler 4 hours ago

    It seems the bug here was caught by Asan instead of at compile time, so basically, for this one bug, rust is reduced to C++-like behavior. You’re still better off using rust because of all the bugs the borrow checker does catch.

    The practical upshot to me is that you should be running your rust tests under asan.

JABVOLT 6 hours ago

very very good job

Rapzid 2 hours ago
  JFC
  I have never seen Rust code
  Threw up in my mouth

Inspired by that Rust code.

  • Rapzid 2 hours ago

    That was a bit generic and easy to swap "Rust" for whatever...

      Dense syntax pulsing
      Writhing and undulating
      What designer, who?